Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-300-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-300-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #300: QUICKSTEP-106: Hash-Join-Fuse: Featur...
Content-Type: text/plain
Message-Id: <20170922193011.9ABBEF3311@git1-us-west.apache.org>
Date: Fri, 22 Sep 2017 19:30:10 +0000 (UTC)
archived-at: Fri, 22 Sep 2017 19:30:17 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575606
  
    --- Diff: query_optimizer/rules/FuseHashSelect.hpp ---
    @@ -0,0 +1,67 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_FUSE_HASH_SELECT_HPP_
    +#define QUICKSTEP_QUERY_OPTIMIZER_RULES_FUSE_HASH_SELECT_HPP_
    +
    +#include <cstdint>
    +#include <memory>
    +#include <string>
    +
    +
    +#include "query_optimizer/physical/HashJoin.hpp"
    +#include "query_optimizer/physical/Physical.hpp"
    +#include "query_optimizer/rules/TopDownRule.hpp"
    +#include "utility/Macros.hpp"
    +
    +namespace quickstep {
    +namespace optimizer {
    +
    +/** \addtogroup OptimizerRules
    + *  @{
    + */
    +
    +/**
    + * @brief Rule that applies to a physical plan to fuse a select node in the 
    + *        build predicate of a hash join to the join.
    + */
    +class FuseHashSelect : public TopDownRule<physical::Physical> {
    + public:
    +    /**
    +     * @brief Constructor.
    +     */
    +    FuseHashSelect() {}
    +
    +    ~FuseHashSelect() override {}
    +
    +    std::string getName() const override {
    +      return "FuseHashSelect";
    +    }
    +
    + protected:
    +    physical::PhysicalPtr applyToNode(const physical::PhysicalPtr &node) override;
    +
    + private:
    +    DISALLOW_COPY_AND_ASSIGN(FuseHashSelect);
    +};
    +
    +}  // namespace optimizer
    +}  // namespace quickstep
    +
    +#endif /* QUICKSTEP_QUERY_OPTIMIZER_RULES_FUSE_HASH_SELECT_HPP_ */
    --- End diff --
    
    The new style is `#endif  // QUICKSTEP_QUERY_OPTIMIZER_RULES_FUSE_HASH_SELECT_HPP_`.


---