quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #301: Bug fix in LockManager loop
Date Fri, 29 Sep 2017 00:41:34 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/301#discussion_r141768111
  
    --- Diff: transaction/LockManager.cpp ---
    @@ -79,22 +79,23 @@ void LockManager::run() {
             const LockRequest request = incoming_requests_.popOne();
             if (request.getRequestType() == RequestType::kReleaseLocks) {
               CHECK(releaseAllLocks(request.getTransactionId()))
    -              << "Unexpected condition occured.";
    -
    +          << "Unexpected condition occured.";
             } else if (acquireLock(request.getTransactionId(),
    -                               request.getResourceId(),
    -                               request.getAccessMode())) {
    +                                request.getResourceId(),
    +                                request.getAccessMode())) {
    --- End diff --
    
    Please align with the first argument.


---

Mime
View raw message