quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #300: QUICKSTEP-106: Hash-Join-Fuse: Featur...
Date Fri, 22 Sep 2017 19:30:32 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/300#discussion_r140569985
  
    --- Diff: query_optimizer/ExecutionGenerator.cpp ---
    @@ -939,6 +939,15 @@ void ExecutionGenerator::convertHashJoin(const P::HashJoinPtr &physical_plan)
{
         query_context_proto_->add_predicates()->CopyFrom(residual_predicate->getProto());
       }
     
    +  // Convert the build predicate proto.
    +  QueryContext::predicate_id build_predicate_index = QueryContext::kInvalidPredicateId;
    +  if (physical_plan->build_predicate()) {
    +    build_predicate_index = query_context_proto_->predicates_size();
    +
    +    unique_ptr<const Predicate> build_predicate(convertPredicate(physical_plan->build_predicate()));
    +    query_context_proto_->add_predicates()->CopyFrom(build_predicate->getProto());
    --- End diff --
    
    Change to `MergeFrom` to avoid an unnecessary reset function call.


---

Mime
View raw message