quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #300: QUICKSTEP-106: Hash-Join-Fuse: Featur...
Date Fri, 22 Sep 2017 19:30:12 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575916
  
    --- Diff: query_optimizer/strategy/Join.cpp ---
    @@ -371,6 +373,7 @@ void Join::addHashJoin(const logical::ProjectPtr &logical_project,
                               left_join_attributes,
                               right_join_attributes,
                               residual_predicate,
    +                          build_predicate,
    --- End diff --
    
    Optionally, I think `E::PredicatePtr()  /* build_predicate */,` is better.


---

Mime
View raw message