quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #281: Simplified the work order generation.
Date Fri, 22 Sep 2017 16:37:44 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/281#discussion_r140540422
  
    --- Diff: query_execution/QueryManagerBase.hpp ---
    @@ -338,6 +285,19 @@ class QueryManagerBase {
        **/
       virtual bool checkRebuildOver(const dag_node_index index) const = 0;
     
    +  /**
    +   * @brief Check if the given operator has ever a normal work order.
    +   *
    +   * @param index The index of the given operator in the DAG.
    +   *
    +   * @return True if the operator has a normal work order, false otherwise.
    +   **/
    +  virtual bool hasEverNormalWorkOrders(const dag_node_index index) const = 0;
    --- End diff --
    
    Suggest to rename this function to ``hasEverProducedNormalWorkOrder`` to make more sense.



---

Mime
View raw message