Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: jianqiao <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-291-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-291-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #291: Add "COPY TO" operator for exporting ...
Content-Type: text/plain
Message-Id: <20170830223743.1ED0BF16B2@git1-us-west.apache.org>
Date: Wed, 30 Aug 2017 22:37:43 +0000 (UTC)
archived-at: Wed, 30 Aug 2017 22:37:48 -0000

Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/291#discussion_r136180815
  
    --- Diff: query_optimizer/logical/CopyFrom.hpp ---
    @@ -66,20 +67,14 @@ class CopyFrom : public Logical {
       const std::string& file_name() const { return file_name_; }
     
       /**
    -   * @return The delimiter used in the text file to separate columns.
    +   * @return The options for this COPY FROM statement.
        */
    -  const char column_delimiter() const { return column_delimiter_; }
    -
    -  /**
    -   * @return Whether to decode escape sequences in the text file.
    -   */
    -  bool escape_strings() const { return escape_strings_; }
    +  BulkIOConfigurationPtr options() const { return options_; }
    --- End diff --
    
    Updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---