Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-291-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-291-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #291: Add "COPY TO" operator for exporting ...
Content-Type: text/plain
Message-Id: <20170830200402.05663F55A1@git1-us-west.apache.org>
Date: Wed, 30 Aug 2017 20:04:01 +0000 (UTC)
archived-at: Wed, 30 Aug 2017 20:04:12 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/291#discussion_r136161344
  
    --- Diff: query_optimizer/resolver/Resolver.cpp ---
    @@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement &parse_query) {
     }
     
     L::LogicalPtr Resolver::resolveCopyFrom(
    -    const ParseStatementCopyFrom &copy_from_statement) {
    -  // Default parameters.
    -  std::string column_delimiter_ = "\t";
    -  bool escape_strings_ = true;
    +    const ParseStatementCopy &copy_from_statement) {
    +  DCHECK(copy_from_statement.getCopyDirection() == ParseStatementCopy::kFrom);
    +  const PtrList<ParseKeyValue> *params = copy_from_statement.params();
     
    -  const ParseCopyFromParams *params = copy_from_statement.params();
    +  BulkIOFormat file_format = BulkIOFormat::kText;
       if (params != nullptr) {
    -    if (params->delimiter != nullptr) {
    -      column_delimiter_ = params->delimiter->value();
    -      if (column_delimiter_.size() != 1) {
    -        THROW_SQL_ERROR_AT(params->delimiter)
    -            << "DELIMITER is not a single character";
    +    for (const ParseKeyValue &param : *params) {
    +      const std::string &key = ToLower(param.key()->value());
    +      if (key == "format") {
    +        const ParseString *parse_format = GetKeyValueString(param);
    +        const std::string format = ToLower(parse_format->value());
    +        // TODO(jianqiao): Support other bulk load formats such as CSV.
    +        if (format != "text") {
    +          THROW_SQL_ERROR_AT(parse_format) << "Unsupported file format: " << format;
    +        }
    +        // Update file_format when other formats get supported.
    +        break;
    +      }
    +    }
    +  }
    +
    +  std::unique_ptr<BulkIOConfiguration> options =
    +      std::make_unique<BulkIOConfiguration>(file_format);
    --- End diff --
    
    How about `auto options = std::make_shared<BulkIOConfiguration>(file_format);`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---