quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #291: Add "COPY TO" operator for exporting ...
Date Wed, 30 Aug 2017 20:04:00 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/291#discussion_r136148771
  
    --- Diff: parser/ParseStatement.hpp ---
    @@ -771,122 +776,135 @@ class ParseStatementInsertSelection : public ParseStatementInsert
{
       DISALLOW_COPY_AND_ASSIGN(ParseStatementInsertSelection);
     };
     
    +
     /**
    - * @brief Optional parameters for a COPY FROM statement.
    + * @brief The parsed representation of a COPY FROM/COPY TO statement.
      **/
    -struct ParseCopyFromParams : public ParseTreeNode {
    -  /**
    -   * @brief Constructor, sets default values.
    -   **/
    -  ParseCopyFromParams(const int line_number, const int column_number)
    -      : ParseTreeNode(line_number, column_number),
    -        escape_strings(true) {
    -  }
    -
    -  std::string getName() const override { return "CopyFromParams"; }
    -
    +class ParseStatementCopy : public ParseStatement {
    + public:
       /**
    -   * @brief Sets the column delimiter.
    -   *
    -   * @param delimiter_in The column delimiter string.
    +   * @brief Copy direction (FROM text file/TO text file).
        */
    -  void set_delimiter(ParseString* delimiter_in) {
    -    delimiter.reset(delimiter_in);
    -  }
    -
    -  /**
    -   * @brief The string which terminates individual attribute values in the
    -   *        input file. Can be NULL.
    -   **/
    -  std::unique_ptr<ParseString> delimiter;
    +  enum CopyDirection {
    +    kFrom,
    --- End diff --
    
    Change to `kFrom = 0,`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message