quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #291: Add "COPY TO" operator for exporting ...
Date Wed, 30 Aug 2017 20:04:01 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/291#discussion_r136158632
  
    --- Diff: query_optimizer/physical/CopyFrom.hpp ---
    @@ -68,22 +69,14 @@ class CopyFrom : public Physical {
       const std::string& file_name() const { return file_name_; }
     
       /**
    -   * @return The delimiter used in the text file to separate columns.
    +   * @return The options for this COPY FROM statement.
        */
    -  const char column_delimiter() const { return column_delimiter_; }
    -
    -  /**
    -   * @return Whether to decode escape sequences in the text file.
    -   */
    -  bool escape_strings() const { return escape_strings_; }
    +  BulkIOConfigurationPtr options() const { return options_; }
    --- End diff --
    
    Return a const ref.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message