Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-232-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-232-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep issue #232: QUICKSTEP-87 Adds network cli interface.
Content-Type: text/plain
Message-Id: <20170424210623.F02E2E038B@git1-us-west.apache.org>
Date: Mon, 24 Apr 2017 21:06:23 +0000 (UTC)
archived-at: Mon, 24 Apr 2017 21:06:29 -0000

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/232
  
    I mean, if this class is always a base class, move the constructor in
    protected session.
    On Mon, Apr 24, 2017 at 12:58 PM Marc S <notifications@github.com> wrote:
    
    > *@cramja* commented on this pull request.
    > ------------------------------
    >
    > In cli/IOInterface.hpp
    > <https://github.com/apache/incubator-quickstep/pull/232#discussion_r113041261>
    > :
    >
    > > + * specific language governing permissions and limitations
    > + * under the License.
    > + **/
    > +
    > +#ifndef QUICKSTEP_CLI_IO_INTERFACE_HPP_
    > +#define QUICKSTEP_CLI_IO_INTERFACE_HPP_
    > +
    > +#include <string>
    > +
    > +/**
    > + * Virtual base defines a generic, file-based interface around IO.
    > + */
    > +class IOInterface {
    > + public:
    > +  IOInterface() {}
    > +
    >
    > I removed the constructor but ran into a compiler error:
    >
    > /Users/cramja/workspace/quickstep/incubator-quickstep/cli/NetworkIO.cpp:50:12: error: constructor for 'quickstep::NetworkIO' must explicitly initialize the base class 'quickstep::IOInterface' which does not have a default constructor
    > NetworkIO::NetworkIO() {
    >            ^
    > /Users/cramja/workspace/quickstep/incubator-quickstep/cli/IOInterface.hpp:62:7: note: 'quickstep::IOInterface' declared here
    > class IOInterface {
    >       ^
    >
    > On doing the suggestion in the output, that too gave a compiler error.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/incubator-quickstep/pull/232#discussion_r113041261>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/ACJDxGtWVm0ZhTjvMb9w0_2D7-hWuOdeks5rzP7OgaJpZM4M_q9a>
    > .
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---