Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-237-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-237-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #237: QUICKSTEP-89 Add support for common s...
Content-Type: text/plain
Message-Id: <20170423222526.80549E178A@git1-us-west.apache.org>
Date: Sun, 23 Apr 2017 22:25:26 +0000 (UTC)
archived-at: Sun, 23 Apr 2017 22:25:32 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/237#discussion_r112827764
  
    --- Diff: expressions/scalar/ScalarCaseExpression.cpp ---
    @@ -420,15 +429,15 @@ void ScalarCaseExpression::MultiplexNativeColumnVector(
     void ScalarCaseExpression::MultiplexIndirectColumnVector(
         const TupleIdSequence *source_sequence,
         const TupleIdSequence &case_matches,
    -    IndirectColumnVector *case_result,
    +    const IndirectColumnVector &case_result,
         IndirectColumnVector *output) {
       if (source_sequence == nullptr) {
         TupleIdSequence::const_iterator output_pos_it = case_matches.begin();
         for (std::size_t input_pos = 0;
    -         input_pos < case_result->size();
    +         input_pos < case_result.size();
              ++input_pos, ++output_pos_it) {
           output->positionalWriteTypedValue(*output_pos_it,
    -                                        case_result->moveTypedValue(input_pos));
    --- End diff --
    
    Remove unused `moveTypedValue` method in `types/containers/ColumnVector.hpp`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---