Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: cramja <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-232-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-232-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...
Content-Type: text/plain
Message-Id: <20170421223046.0D90CF49E6@git1-us-west.apache.org>
Date: Fri, 21 Apr 2017 22:30:46 +0000 (UTC)
archived-at: Fri, 21 Apr 2017 22:30:50 -0000

Github user cramja commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/232#discussion_r112788031
  
    --- Diff: cli/NetworkCliClient.hpp ---
    @@ -0,0 +1,91 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#ifndef QUICKSTEP_CLI_SINGLE_NODE_CLIENT_HPP_
    +#define QUICKSTEP_CLI_SINGLE_NODE_CLIENT_HPP_
    +
    +#include <grpc++/grpc++.h>
    +
    +#include <iostream>
    +#include <memory>
    +#include <string>
    +#include <vector>
    +
    +#include "cli/NetworkCli.grpc.pb.h"
    +#include "cli/NetworkCli.pb.h"
    +
    +#include "gflags/gflags.h"
    +#include "glog/logging.h"
    +
    +using grpc::Channel;
    +using grpc::ClientContext;
    +using grpc::Status;
    +
    +namespace quickstep {
    +
    +/**
    + * A simple wrapper class used to do CLI interactions with QuickstepCLI via the gRPC interface.
    + */
    +class NetworkCliClient {
    + public:
    +  explicit NetworkCliClient(std::shared_ptr<Channel> const &channel)
    --- End diff --
    
    That said, I will change it here because elsewhere in this file, the const-first pattern is followed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---