Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-232-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-232-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...
Content-Type: text/plain
Message-Id: <20170420202457.DE9CEF4A27@git1-us-west.apache.org>
Date: Thu, 20 Apr 2017 20:24:57 +0000 (UTC)
archived-at: Thu, 20 Apr 2017 20:25:04 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/232#discussion_r112411238
  
    --- Diff: cli/NetworkCliClientMain.cpp ---
    @@ -0,0 +1,62 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#include <grpc++/grpc++.h>
    +
    +#include <iostream>
    +#include <istream>
    +#include <memory>
    +#include <string>
    +
    +#include "cli/Flags.hpp"
    +#include "cli/LineReaderBuffered.hpp"
    +#include "cli/NetworkCliClient.hpp"
    +
    +#include "gflags/gflags.h"
    +
    +DECLARE_int32(port);
    +
    +using quickstep::LineReaderBuffered;
    +using quickstep::NetworkCliClient;
    +
    +int main(int argc, char **argv) {
    +  google::InitGoogleLogging(argv[0]);
    +  gflags::ParseCommandLineFlags(&argc, &argv, true);
    +
    +  // Attempts to send a single query retrieved from stdin to the Quickstep Server.
    +  NetworkCliClient qs_client(
    +    grpc::CreateChannel("localhost:" + std::to_string(quickstep::FLAGS_port),
    --- End diff --
    
    Add two more whitespace indentation, and we need one more flag for the ip address, instead of `localhost`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---