Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-230-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-230-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #230: Initial SingleNodeClient implementati...
Content-Type: text/plain
Message-Id: <20170408183647.31A87DFD9C@git1-us-west.apache.org>
Date: Sat,  8 Apr 2017 18:36:47 +0000 (UTC)
archived-at: Sat, 08 Apr 2017 18:36:52 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/230#discussion_r110523885
  
    --- Diff: CMakeLists.txt ---
    @@ -696,7 +697,8 @@ set(ENABLE_ZOOKEEPER OFF CACHE BOOL "Enable Zookeeper TMB")
     add_subdirectory("${THIRD_PARTY_SOURCE_DIR}/tmb" "${CMAKE_CURRENT_BINARY_DIR}/third_party/tmb")
     include_directories(${TMB_INCLUDE_DIRS})
     
    -if (ENABLE_DISTRIBUTED)
    +# Single node server requires this for gRPC headers
    +if (ENABLE_DISTRIBUTED OR ENABLE_SINGLE_NODE_SERVER)
    --- End diff --
    
    Reset the change, as `gRPC` does not come from `TMB`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---