Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-229-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-229-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #229: Implement parser and resolver for UNI...
Content-Type: text/plain
Message-Id: <20170407021726.2495BF21A4@git1-us-west.apache.org>
Date: Fri,  7 Apr 2017 02:17:26 +0000 (UTC)
archived-at: Fri, 07 Apr 2017 02:17:32 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/229#discussion_r110300978
  
    --- Diff: query_optimizer/logical/SetOperation.hpp ---
    @@ -0,0 +1,182 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#ifndef QUICKSTEP_QUERY_OPTIMIZER_LOGICAL_SET_OPERATION_HPP_
    +#define QUICKSTEP_QUERY_OPTIMIZER_LOGICAL_SET_OPERATION_HPP_
    +
    +#include <string>
    +#include <type_traits>
    +#include <vector>
    +
    +#include "query_optimizer/OptimizerTree.hpp"
    +#include "query_optimizer/expressions/AttributeReference.hpp"
    +#include "query_optimizer/logical/Logical.hpp"
    +#include "query_optimizer/logical/LogicalType.hpp"
    +#include "utility/Cast.hpp"
    +#include "utility/Macros.hpp"
    +
    +#include "glog/logging.h"
    +
    +namespace quickstep {
    +namespace optimizer {
    +namespace logical {
    +
    +/** \addtogroup OptimizerLogical
    + *  @{
    + */
    +
    +class SetOperation;
    +typedef std::shared_ptr<const SetOperation> SetOperationPtr;
    +
    +/**
    + * @brief Base class for logical set operation operator that combines tuples
    + *        from two or more relations.
    + */
    +class SetOperation : public Logical {
    + public:
    +  enum SetOperationType {
    +    kIntersect,
    --- End diff --
    
    Please change to `kIntersect = 0,`. Also, I'm curious about `kSingle`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---