quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cramja <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #228: Refactored out proto GenerateCPP func...
Date Thu, 06 Apr 2017 20:50:30 GMT
GitHub user cramja opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/228

    Refactored out proto GenerateCPP function

    Refactored out the GenProto methods from the main cmakelist. This cuts down on clutter
and is something I ran into when making the single-node-server.
    
    I also added some comments in the new cmake file.
    
    @zuyu could you review?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cramja/incubator-quickstep refactor-cmake-fn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #228
    
----
commit aac91b43751b134e66544d6ba7b0ddc28538a453
Author: cramja <marc.spehlmann@gmail.com>
Date:   2017-04-06T20:40:43Z

    Refactored out proto GenerateCPP function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message