quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #237: QUICKSTEP-89 Add support for common s...
Date Mon, 24 Apr 2017 21:58:14 GMT
Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/237#discussion_r113066931
  
    --- Diff: expressions/scalar/ScalarCaseExpression.cpp ---
    @@ -420,15 +429,15 @@ void ScalarCaseExpression::MultiplexNativeColumnVector(
     void ScalarCaseExpression::MultiplexIndirectColumnVector(
         const TupleIdSequence *source_sequence,
         const TupleIdSequence &case_matches,
    -    IndirectColumnVector *case_result,
    +    const IndirectColumnVector &case_result,
         IndirectColumnVector *output) {
       if (source_sequence == nullptr) {
         TupleIdSequence::const_iterator output_pos_it = case_matches.begin();
         for (std::size_t input_pos = 0;
    -         input_pos < case_result->size();
    +         input_pos < case_result.size();
              ++input_pos, ++output_pos_it) {
           output->positionalWriteTypedValue(*output_pos_it,
    -                                        case_result->moveTypedValue(input_pos));
    --- End diff --
    
    `moveTypedValue ` still makes sense as a public method that might be used in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message