quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #240: Fix the issues with the common subexp...
Date Mon, 24 Apr 2017 20:13:09 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/240#discussion_r113044397
  
    --- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
    @@ -111,7 +111,7 @@ class ExtractCommonSubexpression : public Rule<physical::Physical>
{
       bool visitAndCount(
           const expressions::ExpressionPtr &expression,
           ScalarCounter *counter,
    -      ScalarHashable *hashable);
    +      ScalarHashable *hashable) const;
    --- End diff --
    
    All methods below in this file could be marked as `const`:
    
    * `transformExpressions`
    * `transformExpression`
    * `visitAndTransform`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message