quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #239: Add ThreadPrivateCompactKeyHashTable ...
Date Mon, 24 Apr 2017 18:03:10 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    --- Diff: storage/AggregationOperationState.cpp ---
    @@ -715,7 +719,18 @@ void AggregationOperationState::finalizeHashTable(
         finalizeHashTableImplPartitioned(partition_id, output_destination);
       } else {
         DCHECK_EQ(0u, partition_id);
    -    finalizeHashTableImplThreadPrivate(output_destination);
    +    DCHECK(group_by_hashtable_pool_ != nullptr);
    +    switch (group_by_hashtable_pool_->getHashTableImplType()) {
    +      case HashTableImplType::kSeparateChaining:
    --- End diff --
    It's better if we are consistent in naming the HashTableImplType and the corresponding
finalize hash table function name. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message