quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #237: QUICKSTEP-89 Add support for common s...
Date Sun, 23 Apr 2017 22:25:26 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/237#discussion_r112826967
  
    --- Diff: expressions/scalar/ScalarAttribute.cpp ---
    @@ -139,25 +142,26 @@ ColumnVector* ScalarAttribute::getAllValues(ValueAccessor *accessor,
               }
             }
           }
    -      return result;
    +      return ColumnVectorPtr(result);
    --- End diff --
    
    Is the conversion required? I think `result` will be implicitly wrapped to a shared pointer
(aka `ColumnVectorPtr`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message