quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...
Date Sun, 23 Apr 2017 06:54:41 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819519
  
    --- Diff: cli/IOInterface.hpp ---
    @@ -0,0 +1,82 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#ifndef QUICKSTEP_CLI_IO_INTERFACE_HPP_
    +#define QUICKSTEP_CLI_IO_INTERFACE_HPP_
    +
    +#include <cstdio>
    +#include <string>
    +
    +#include "utility/Macros.hpp"
    +
    +namespace quickstep {
    +
    +/**
    + * An individual IO interaction with Quickstep.
    + */
    +class IOHandle {
    + public:
    +  IOHandle() {}
    +
    +  /**
    +   * @note Destructor should handle clean up of any IO state.
    +   */
    +  virtual ~IOHandle() {}
    +
    +  /**
    +   * @return A file handle for standard output.
    +   */
    +  virtual FILE *out() = 0;
    +
    +  /**
    +   * @return A file handle for error output.
    +   */
    +  virtual FILE *err() = 0;
    +
    +  virtual std::string getCommand() = 0;
    --- End diff --
    
    Could we mark `getCommand` `const`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message