quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...
Date Sat, 22 Apr 2017 00:48:01 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/232#discussion_r112797758
  
    --- Diff: CMakeLists.txt ---
    @@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
       )
     endif()
     
    +option(ENABLE_NETWORK_CLI "Allows use of the network cli" ON)
    --- End diff --
    
    The problem is, if we check in this PR, by default we will build the network-based client
for the single-node version, no matter whether the machine has `grpc` installed or not. And
typically, it will fail due to no `grpc` found.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message