quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cramja <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...
Date Fri, 21 Apr 2017 22:25:55 GMT
Github user cramja commented on a diff in the pull request:

    --- Diff: cli/NetworkCliClient.hpp ---
    @@ -0,0 +1,91 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +#include <grpc++/grpc++.h>
    +#include <iostream>
    +#include <memory>
    +#include <string>
    +#include <vector>
    +#include "cli/NetworkCli.grpc.pb.h"
    +#include "cli/NetworkCli.pb.h"
    +#include "gflags/gflags.h"
    +#include "glog/logging.h"
    +using grpc::Channel;
    +using grpc::ClientContext;
    +using grpc::Status;
    +namespace quickstep {
    + * A simple wrapper class used to do CLI interactions with QuickstepCLI via the gRPC
    + */
    +class NetworkCliClient {
    + public:
    +  explicit NetworkCliClient(std::shared_ptr<Channel> const &channel)
    --- End diff --
    FYI the style guide says this is a matter of preference
    > That said, while we encourage putting const first, we do not require it. But be consistent
with the code around you!
    My opinion is that it should always follow the target object because then it will always
be consistent.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message