quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cramja <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #234: Add protobuf support for UNION ALL op...
Date Wed, 19 Apr 2017 22:59:09 GMT
Github user cramja commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/234#discussion_r112333067
  
    --- Diff: relational_operators/UnionAllOperator.cpp ---
    @@ -128,14 +128,56 @@ bool UnionAllOperator::getAllWorkOrders(
     }
     
     bool UnionAllOperator::getAllWorkOrderProtos(WorkOrderProtosContainer* container) {
    -  // TODO(tianrun): Add protobuf for UnionAllWorkOrder to support distributed mode.
    -  LOG(FATAL) << "UnionAllOperator is not supported in distributed mode yet.";
    -  return true;
    +  if (!stored_generated_) {
    +    for (std::size_t relation_index = 0; relation_index < input_relations_.size();
++relation_index) {
    --- End diff --
    
    I'd suggest to refactor this into a small `generateStored (?)` method, because it seems
like isolatable functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message