quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #232: QUICKSTEP-87 Adds network cli interfa...
Date Wed, 19 Apr 2017 16:18:46 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/232#discussion_r112248871
  
    --- Diff: cli/Flags.cpp ---
    @@ -87,4 +87,15 @@ DEFINE_bool(preload_buffer_pool, false,
                 "accepting queries (should also set --buffer_pool_slots to be "
                 "large enough to accomodate the entire database).");
     
    +static bool ValidatePort(const char *flagname, std::int32_t value) {
    +  if (value > 0 && value < 65536) {
    +    return true;
    +  }
    +  std::cout << "Invalid value for --" << flagname << ": " <<
std::to_string(value) << std::endl;
    --- End diff --
    
    Should the error message also include the valid range of values? That might be helpful.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message