quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cramja <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #230: Initial SingleNodeClient implementation
Date Sun, 09 Apr 2017 14:00:38 GMT
Github user cramja commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/230
  
    @zuyu Thank you for the review
    
    Here's a possibility based on your overall comment: I could add the IOBase and its subclass
GrpcWrapper to this PR. The IOBase abstracts around all IO (including LineReaders). The GrpcWrapper
is a wrapper around server side interactions. Then the unit test would test communication
between GrpcWrapper and the Client.
    
    I was thinking to add 1 new executable to Quickstep, that being the dumb client. All it
really is is an interface for a user to send a query through. It just handles send and receive,
therefore does no parsing/etc. That can come later if we want.
    
    Then in another PR the Cli exe can be modified to have the `--mode=server` option as you
suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message