quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #230: Initial SingleNodeClient implementati...
Date Sat, 08 Apr 2017 18:36:47 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524006
  
    --- Diff: cli/CMakeLists.txt ---
    @@ -44,6 +44,20 @@ configure_file (
       "${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
     )
     
    +# Compile the protos for Single Node Server mode.
    +if(ENABLE_SINGLE_NODE_SERVER)
    +  # We will need some of the TMBs libraries
    +  set(CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/third_party/src/tmb/cmake")
    +
    +  find_package(Grpc++ REQUIRED)
    +  include_directories(${GRPCPLUSPLUS_INCLUDE_DIRS})
    --- End diff --
    
    We should move above to the root `cmake` file. Also, it should look like
    
    ```
      set(CMAKE_MODULE_PATH "$CMAKE_MODULE_PATH"
                            "${PROJECT_SOURCE_DIR}/third_party/src/tmb/cmake")
    
      find_package(Grpc++ REQUIRED)
      include_directories(${GRPCPLUSPLUS_INCLUDE_DIRS})
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message