Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1EF33200C43 for ; Sun, 26 Mar 2017 19:11:30 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1DA6B160B87; Sun, 26 Mar 2017 17:11:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 65A2B160B82 for ; Sun, 26 Mar 2017 19:11:29 +0200 (CEST) Received: (qmail 70902 invoked by uid 500); 26 Mar 2017 17:11:27 -0000 Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quickstep.incubator.apache.org Delivered-To: mailing list dev@quickstep.incubator.apache.org Received: (qmail 70885 invoked by uid 99); 26 Mar 2017 17:11:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Mar 2017 17:11:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BB1E21A00AF for ; Sun, 26 Mar 2017 17:11:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id k2FKHfG1Mqx3 for ; Sun, 26 Mar 2017 17:11:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 262785F245 for ; Sun, 26 Mar 2017 17:11:24 +0000 (UTC) Received: (qmail 70878 invoked by uid 99); 26 Mar 2017 17:11:24 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Mar 2017 17:11:24 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 27678DFF0F; Sun, 26 Mar 2017 17:11:24 +0000 (UTC) From: hbdeshmukh To: dev@quickstep.incubator.apache.org Reply-To: dev@quickstep.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-quickstep issue #217: QUICKSTEP-73: Multi-attribute PartitionSchem... Content-Type: text/plain Message-Id: <20170326171124.27678DFF0F@git1-us-west.apache.org> Date: Sun, 26 Mar 2017 17:11:24 +0000 (UTC) archived-at: Sun, 26 Mar 2017 17:11:30 -0000 Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/217 Hi @zuyu Looks good to me. I just have one last comment about the commented code in unit tests. After that, we should be good to go. Also, there are two commits for this PR, would you mind squashing them to one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---