quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cramja <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #204: Cmake changes for default build
Date Fri, 03 Mar 2017 23:07:14 GMT
GitHub user cramja opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/204

    Cmake changes for default build

    This fixes two annoying build issues
    
    1. If the CMAKEBUILDTYPE is not set by the user, it previously defaulted to none-type
which caused one of our tests to fail. It is now set to RelWithDebInfo if no build type is
set. Code take from [link](https://github.com/miloyip/rapidjson/issues/319)
    2. When building on Mac, the default setting of TCMALLOC would cause a compiler error.
We fix this by disabling TCMALLOC on Mac
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cramja/incubator-quickstep set-default-cmake-build

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #204
    
----
commit bc652a553a65af12b5bf75e27c7e7aec8c35d822
Author: cramja <marc.spehlmann@gmail.com>
Date:   2017-03-03T23:04:44Z

    Cmake changes for default build

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message