quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #217: QUICKSTEP-73: Multi-attribute PartitionSchem...
Date Sun, 26 Mar 2017 17:11:24 GMT
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/217
  
    Hi @zuyu 
    
    Looks good to me. I just have one last comment about the commented code in unit tests.
After that, we should be good to go. Also, there are two commits for this PR, would you mind
squashing them to one? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message