quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #217: QUICKSTEP-73: Multi-attribute Partiti...
Date Fri, 24 Mar 2017 18:59:04 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/217#discussion_r107977156
  
    --- Diff: storage/InsertDestination.cpp ---
    @@ -682,8 +685,11 @@ void PartitionAwareInsertDestination::bulkInsertTuplesWithRemappedAttributes(
         // set a bit in the appropriate TupleIdSequence.
         accessor->beginIteration();
         while (accessor->next()) {
    -      TypedValue attr_val = accessor->getTypedValue(attribute_map[partition_attribute_id]);
    -      partition_membership[partition_scheme_header_->getPartitionId(attr_val)]
    +      PartitionSchemeHeader::PartitionValues values;
    +      for (const attribute_id attr_id : partition_scheme_header_->getPartitionAttributeIds())
{
    +        values.push_back(accessor->getTypedValue(attr_id));
    +      }
    --- End diff --
    
    Did you take a look at the function ``getTupleWithAttributes()``. It may be useful here.
Moreover the ``tuple`` class can compute hash using the ``getTupleHash`` function. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message