quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #217: QUICKSTEP-73: Multi-attribute Partiti...
Date Fri, 24 Mar 2017 17:00:58 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/217#discussion_r107951792
  
    --- Diff: catalog/tests/PartitionScheme_unittest.cpp ---
    @@ -343,15 +363,43 @@ TEST(PartitionSchemeHeaderTest, VarCharRangePartitionSchemeHeaderTest)
{
       for (size_t i = 0; i < num_strings; ++i) {
         EXPECT_EQ(kExpectedPartitions[i],
                   partition_scheme_header->getPartitionId(
    -                  TypedValue(kVarChar,
    -                             kSampleStrings[i],
    -                             std::strlen(kSampleStrings[i]) + 1)));
    +                  { TypedValue(kVarChar, kSampleStrings[i], std::strlen(kSampleStrings[i])
+ 1) }));
       }
     }
     
    +TEST(PartitionSchemeHeaderTest, MultiAttributeRangePartitionSchemeHeaderTest) {
    +  vector<PartitionSchemeHeader::PartitionValues> partition_ranges;
    +  // Partition boundaries are { 0, 0.00000 }, { 10, 10.0000 }, { 20, 20.00000 }
    +  // Last partition can hold upto infinity.
    +  // First partition can hold from { -infinity, -infinity } to { 0, -2^(-1074) }.
    --- End diff --
    
    Can you explain -2^(-1074)? I thought the first partition should be < {0, 0.0000} and
> {-Inf, -Inf}. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message