quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #217: QUICKSTEP-73: Multi-attribute Partiti...
Date Fri, 24 Mar 2017 16:50:00 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/217#discussion_r107949434
  
    --- Diff: catalog/PartitionSchemeHeader.hpp ---
    @@ -249,20 +269,22 @@ class RangePartitionSchemeHeader : public PartitionSchemeHeader
{
        * @brief Calulate the partition id into which the attribute value
        *        should be inserted.
        *
    -   * @param value_of_attribute The attribute value for which the
    -   *                           partition id is to be determined.
    +   * @param value_of_attributes The attribute value for which the
    --- End diff --
    
    Nitpick - values instead of value. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message