quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #217: QUICKSTEP-73: Multi-attribute Partiti...
Date Thu, 23 Mar 2017 17:52:29 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/217#discussion_r107739146
  
    --- Diff: catalog/PartitionSchemeHeader.cpp ---
    @@ -32,16 +34,29 @@
     
     #include "glog/logging.h"
     
    +using std::move;
    +using std::size_t;
    +using std::vector;
    +
     namespace quickstep {
     
     PartitionSchemeHeader::PartitionSchemeHeader(const PartitionType type,
                                                  const std::size_t num_partitions,
    -                                             const attribute_id attr_id)
    +                                             PartitionAttributeIds &&attr_ids)
 // NOLINT(whitespace/operators)
         : partition_type_(type),
           num_partitions_(num_partitions),
    -      partition_attribute_id_(attr_id) {
    +      partition_attribute_ids_(move(attr_ids)) {
       DCHECK_GT(num_partitions, 0u);
    -  DCHECK_GE(attr_id, 0);
    +
    +#ifdef QUICKSTEP_DEBUG
    --- End diff --
    
    Optional, but a couple of lines regarding what you are trying to do here should be helpful.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message