quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #181: Added limited optimizer support for P...
Date Tue, 07 Mar 2017 01:52:31 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/181#discussion_r104572226
  
    --- Diff: query_optimizer/ExecutionGenerator.cpp ---
    @@ -679,13 +688,72 @@ void ExecutionGenerator::convertFilterJoin(const P::FilterJoinPtr
&physical_plan
           std::piecewise_construct,
           std::forward_as_tuple(physical_plan),
           std::forward_as_tuple(probe_relation_info->producer_operator_index,
    -                            probe_relation_info->relation));
    +                            probe_relation_info->relation,
    +                            probe_relation_info->output_destination_index));
     
       DCHECK(lip_filter_generator_ != nullptr);
       lip_filter_generator_->addFilterJoinInfo(physical_plan,
                                                build_filter_operator_index);
     }
     
    +namespace {
    +
    +bool areSamePartitionSchemeHeaders(const PartitionSchemeHeader &lhs_partition_header,
    --- End diff --
    
    These functions in the anonymous namespace may better be defined in some other source
file. This cpp file is getting monstrously big, and any efforts to reduce its size should
be welcome. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message