Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: jianqiao <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-180-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-180-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #180: Fix the bug with SingleIdentityHashFi...
Content-Type: text/plain
Message-Id: <20170207161454.C5B82DFBE6@git1-us-west.apache.org>
Date: Tue,  7 Feb 2017 16:14:54 +0000 (UTC)
archived-at: Tue, 07 Feb 2017 16:14:59 -0000

Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/180#discussion_r99859847
  
    --- Diff: query_optimizer/rules/AttachLIPFilters.cpp ---
    @@ -128,7 +129,7 @@ void AttachLIPFilters::attachLIPFilters(
               lip_filter_configuration_->addBuildInfo(
                   P::SingleIdentityHashFilterBuildInfo::Create(
                       pair.second->source_attribute,
    -                  pair.second->estimated_cardinality * 8),
    +                  std::max(64uL, pair.second->estimated_cardinality * 8u)),
    --- End diff --
    
    It seems that we won't need to change this value. If there are scenarios later that the configuration of this value makes a difference, then we can add a flag for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---