Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-179-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-179-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...
Content-Type: text/plain
Message-Id: <20170206051248.2AFE2E0433@git1-us-west.apache.org>
Date: Mon,  6 Feb 2017 05:12:48 +0000 (UTC)
archived-at: Mon, 06 Feb 2017 05:12:54 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/179#discussion_r99511739
  
    --- Diff: storage/AggregationOperationState.hpp ---
    @@ -156,6 +152,29 @@ class AggregationOperationState {
           const CatalogDatabaseLite &database);
     
       /**
    +   * @brief Get the number of partitions to be used for initializing the
    +   *        aggregation.
    +   *
    +   * @return The number of partitions to be used for initializing the aggregation.
    +   **/
    +  std::size_t getNumInitializationPartitions() const;
    +
    +  /**
    +   * @brief Get the number of partitions to be used for finalizing the
    +   *        aggregation.
    +   *
    +   * @return The number of partitions to be used for finalizing the aggregation.
    +   **/
    +  std::size_t getNumFinalizationPartitions() const;
    --- End diff --
    
    I was wondering why `getNumInitializationPartitions` may be different than `getNumFinalizationPartitions`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---