quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #185: Fuse Aggregate with HashLeftOuterJoin...
Date Thu, 09 Feb 2017 18:03:47 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/185#discussion_r100369492
  
    --- Diff: relational_operators/WorkOrder.proto ---
    @@ -44,6 +44,7 @@ enum WorkOrderType {
       UPDATE = 20;
       WINDOW_AGGREGATION = 21;
       DESTROY_AGGREGATION_STATE = 22;
    +  BUILD_AGGREGATION_EXISTENCE_MAP = 23;
    --- End diff --
    
    Please sort the type in the alphabet order (similarly to `BuildAggregationExistenceMapWorkOrder`
below), and add the following comment above `enum WorkOrderType {`:
    
    ```
    // Next tag: 24.
    enum WorkOrderType {
    ```
    
    Recall that this is how Google deals with changing proto definitions. And `Next tag` is
the next available number to assign to a new type. After adding the new type, we need to increase
`Next tag` by one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message