quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...
Date Tue, 07 Feb 2017 20:37:49 GMT
Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/179#discussion_r99922836
  
    --- Diff: relational_operators/InitializeAggregationOperator.cpp ---
    @@ -0,0 +1,72 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#include "relational_operators/InitializeAggregationOperator.hpp"
    +
    +#include <cstddef>
    +
    +#include "query_execution/QueryContext.hpp"
    +#include "query_execution/WorkOrderProtosContainer.hpp"
    +#include "query_execution/WorkOrdersContainer.hpp"
    +#include "relational_operators/WorkOrder.pb.h"
    +#include "storage/AggregationOperationState.hpp"
    +
    +#include "glog/logging.h"
    +
    +#include "tmb/id_typedefs.h"
    +
    +namespace quickstep {
    +
    +bool InitializeAggregationOperator::getAllWorkOrders(
    +    WorkOrdersContainer *container,
    +    QueryContext *query_context,
    +    StorageManager *storage_manager,
    +    const tmb::client_id scheduler_client_id,
    +    tmb::MessageBus *bus) {
    +  if (!started_) {
    +    AggregationOperationState *agg_state =
    +        query_context->getAggregationState(aggr_state_index_);
    +    DCHECK(agg_state != nullptr);
    +
    +    for (std::size_t part_id = 0;
    +         part_id < agg_state->getNumInitializationPartitions();
    +         ++part_id) {
    +      container->addNormalWorkOrder(
    +          new InitializeAggregationWorkOrder(query_id_,
    +                                             part_id,
    +                                             agg_state),
    +          op_index_);
    +    }
    +    started_ = true;
    +  }
    +  return true;
    +}
    +
    +// TODO(quickstep-team) : Think about how the number of partitions could be
    +// accessed in this function. Until then, we can't use partitioned aggregation
    +// initialization with the distributed version.
    --- End diff --
    
    The "partition" here is kind of inner-table partitioning that is not related to the partitioning
of storage blocks. To get the "number of partitions" here, we need the "AggregationOperationState"
object, which is not available at this moment.
    
    One solution is to calculate the # of partitions value before creating the `AggregationOperationState`
object. That requires quite some refactoring. We can see if we need to do that later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message