quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...
Date Tue, 07 Feb 2017 17:46:32 GMT
Github user jianqiao commented on a diff in the pull request:

    --- Diff: query_optimizer/ExecutionGenerator.hpp ---
    @@ -427,7 +445,7 @@ class ExecutionGenerator {
        * @brief The cost model to use for estimating aggregation hash table size.
    -  std::unique_ptr<cost::CostModel> cost_model_for_aggregation_;
    +  std::unique_ptr<cost::StarSchemaSimpleCostModel> cost_model_for_aggregation_;
    --- End diff --
    We need some extra analysis done in `StarSchemaSimpleCostModel`. I will refactor the analysis
part out of `StarSchemaSimpleCostModel` into `AnalysisUtil` in a follow-up PR.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message