quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #180: Fix the bug with SingleIdentityHashFi...
Date Tue, 07 Feb 2017 16:14:54 GMT
Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/180#discussion_r99859847
  
    --- Diff: query_optimizer/rules/AttachLIPFilters.cpp ---
    @@ -128,7 +129,7 @@ void AttachLIPFilters::attachLIPFilters(
               lip_filter_configuration_->addBuildInfo(
                   P::SingleIdentityHashFilterBuildInfo::Create(
                       pair.second->source_attribute,
    -                  pair.second->estimated_cardinality * 8),
    +                  std::max(64uL, pair.second->estimated_cardinality * 8u)),
    --- End diff --
    
    It seems that we won't need to change this value. If there are scenarios later that the
configuration of this value makes a difference, then we can add a flag for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message