quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...
Date Mon, 06 Feb 2017 05:12:48 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/179#discussion_r99511761
  
    --- Diff: storage/AggregationOperationState.hpp ---
    @@ -156,6 +152,29 @@ class AggregationOperationState {
           const CatalogDatabaseLite &database);
     
       /**
    +   * @brief Get the number of partitions to be used for initializing the
    +   *        aggregation.
    +   *
    +   * @return The number of partitions to be used for initializing the aggregation.
    +   **/
    +  std::size_t getNumInitializationPartitions() const;
    +
    +  /**
    +   * @brief Get the number of partitions to be used for finalizing the
    +   *        aggregation.
    +   *
    +   * @return The number of partitions to be used for finalizing the aggregation.
    +   **/
    +  std::size_t getNumFinalizationPartitions() const;
    +
    +  /**
    +   * @brief Initialize the specified partition of this aggregation.
    +   *
    +   * @param partition_id ID of the partition to be initialized.
    +   */
    +  void initialize(const std::size_t partition_id);
    --- End diff --
    
    Use `partition_id` type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message