quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...
Date Mon, 06 Feb 2017 05:12:48 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/179#discussion_r99505112
  
    --- Diff: relational_operators/FinalizeAggregationOperator.hpp ---
    @@ -116,29 +116,29 @@ class FinalizeAggregationWorkOrder : public WorkOrder {
        * @note InsertWorkOrder takes ownership of \c state.
        *
        * @param query_id The ID of the query to which this operator belongs.
    +   * @param partition_id The partition ID for which the Finalize aggregation
    +   *        work order is issued.
        * @param state The AggregationState to use.
        * @param output_destination The InsertDestination to insert aggregation
        *        results.
    -   * @param part_id The partition ID for which the Finalize aggregation work
    -   *        order is issued. Ignore if aggregation is not partitioned.
        */
       FinalizeAggregationWorkOrder(const std::size_t query_id,
    +                               const std::size_t partition_id,
    --- End diff --
    
    Please replace `size_t` with `partition_id` defined in `catalog/CatalogTypedefs.hpp`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message