quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...
Date Mon, 06 Feb 2017 05:12:48 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/179#discussion_r99505348
  
    --- Diff: storage/AggregationOperationState.cpp ---
    @@ -80,148 +83,145 @@ AggregationOperationState::AggregationOperationState(
         const std::vector<HashTableImplType> &distinctify_hash_table_impl_types,
         StorageManager *storage_manager)
         : input_relation_(input_relation),
    -      is_aggregate_partitioned_(checkAggregatePartitioned(
    -          estimated_num_entries, is_distinct, group_by, aggregate_functions)),
    +      is_aggregate_collision_free_(false),
    +      is_aggregate_partitioned_(false),
    --- End diff --
    
    FYI, in the hash join, we have a fixed number of hash tables, and treat no partition case
as `num_partitions` is one.
    
    I think we could do similar for the aggregation, and pass the fixed `num_partitions` from
the optimizer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message