quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #179: QUICKSTEP-70-71 Improve aggregation p...
Date Mon, 06 Feb 2017 05:12:27 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/179#discussion_r99505207
  
    --- Diff: relational_operators/WorkOrderFactory.cpp ---
    @@ -186,6 +186,7 @@ WorkOrder* WorkOrderFactory::ReconstructFromProto(const serialization::WorkOrder
           LOG(INFO) << "Creating FinalizeAggregationWorkOrder in Shiftboss " <<
shiftboss_index;
           return new FinalizeAggregationWorkOrder(
               proto.query_id(),
    +          0uL,
    --- End diff --
    
    partition_id?
    
    Please add a `TODO: refactor using partition_id from proto, like BuildHashWorkOrder`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message