quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #:
Date Fri, 03 Feb 2017 20:49:31 GMT
Github user zuyu commented on the pull request:

    https://github.com/apache/incubator-quickstep/commit/4f8fdbe8451aed1ad1c07a8badb5be85bee1ff57#commitcomment-20738480
  
    In relational_operators/TextScanOperator.cpp:
    In relational_operators/TextScanOperator.cpp on line 129:
    I encountered the `TextScanReadError` exception when loading the SF-100 `lineorder` table
(~59 GB) in the distributed version, and after changing the if-condition to `bytes_read !=
text_segment_size_ && !std::feof(file)`, it passes the text-scan part.
    
    Note that without any changes, all other small tables have no such issue.
    
    Actually, I am worry about the way you get the file size using `fseek` and `ftell`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message