Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: jianqiao <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-165-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-165-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #165: Added Operator support for Partitione...
Content-Type: text/plain
Message-Id: <20170120220715.012A6DFA43@git1-us-west.apache.org>
Date: Fri, 20 Jan 2017 22:07:15 +0000 (UTC)
archived-at: Fri, 20 Jan 2017 22:07:54 -0000

Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/165#discussion_r97165573
  
    --- Diff: storage/StorageBlockInfo.hpp ---
    @@ -49,6 +50,8 @@ static constexpr int kBlockIdDomainLengthInDigits = std::numeric_limits<block_id
     static constexpr int kBlockIdCounterLengthInDigits = std::numeric_limits<block_id_counter>::digits10;
     static constexpr block_id_domain kMaxDomain = static_cast<block_id_domain>(0xFFFF);
     
    +typedef std::vector<block_id> blocks_in_partition;
    --- End diff --
    
    `block_in_partition` is not a primitive type. Perhaps use `BlockInPartition`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---