quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...
Date Tue, 31 Jan 2017 16:29:20 GMT
Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/174#discussion_r98708887
  
    --- Diff: query_optimizer/PhysicalGenerator.cpp ---
    @@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan(
     P::PhysicalPtr PhysicalGenerator::optimizePlan() {
       std::vector<std::unique_ptr<Rule<P::Physical>>> rules;
       rules.emplace_back(new PruneColumns());
    +  rules.emplace_back(new PushDownLowCostDisjunctivePredicate());
    --- End diff --
    
    The three rules blocks from `PushDownLowCostDisjunctivePredicate` to `ReorderColumns`
can be arranged in any order.
    
    `PushDownLowCostDisjunctivePredicate` will not generate unnecessary `Selection`s. And
currently in the physical generate there's no rule that fuses `Selection`s.
    
    I add a comment to indicate that currently new rules should better be added before `AttachLIPFilters`
because rules after that needs extra handling of `LIPFilterConfiguration` for transformed
nodes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message