quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #174: Push down disjunctive predicates to f...
Date Tue, 31 Jan 2017 15:38:05 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/174#discussion_r98689643
  
    --- Diff: query_optimizer/PhysicalGenerator.cpp ---
    @@ -108,6 +109,7 @@ P::PhysicalPtr PhysicalGenerator::generateInitialPlan(
     P::PhysicalPtr PhysicalGenerator::optimizePlan() {
       std::vector<std::unique_ptr<Rule<P::Physical>>> rules;
       rules.emplace_back(new PruneColumns());
    +  rules.emplace_back(new PushDownLowCostDisjunctivePredicate());
    --- End diff --
    
    Could we have some comments regarding the order of `rules`, i.e., why put `PushDownLowCostDisjunctivePredicate`
here?
    
    If I understand correctly, `PushDownLowCostDisjunctivePredicate` may generate new `Physical
Select`s. Would the rest of `rules` eliminate multiple `Physical Select`s into one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message