quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...
Date Mon, 30 Jan 2017 06:54:54 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/171#discussion_r98384582
  
    --- Diff: relational_operators/HashJoinOperator.cpp ---
    @@ -484,7 +565,38 @@ void HashInnerJoinWorkOrder::execute() {
       const relation_id build_relation_id = build_relation_.getID();
       const relation_id probe_relation_id = probe_relation_.getID();
     
    -  for (std::pair<const block_id, std::pair<std::vector<tuple_id>, std::vector<tuple_id>>>
    +  // Create a map of ValueAccessors and what attributes we want to pick from them.
    +  std::vector<std::pair<ValueAccessor *, std::vector<attribute_id>>>
accessor_attribute_map;
    +  const std::size_t build_index = 0, probe_index = 1, temp_index = 2;
    +  for (std::size_t i = 0; i < 3; ++i) {
    +    accessor_attribute_map.emplace_back(
    +        nullptr /* place holder */,
    --- End diff --
    
    Change the comment to `place holder for a late binding ValueAccessor`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message